ci: pin contents: read on the 3 remaining PR checks#1402
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for cncf-license-exceptions canceled.
|
…ceptions All three workflows are read-only PR checks (playwright e2e for the license-exceptions site, CSV format validation, and JSON Schema validation). No GitHub API writes. Signed-off-by: arpitjain099 <arpitjain099@gmail.com>
arpitjain099
force-pushed
the
ci/add-permissions
branch
from
ff9cb80 to
33d4ed5
Compare
Author
|
Hi @riaankleinhans, gentle ping on this. PR has been open for 4 days without review. I noticed you've been on the recent-merger side of recent merges in this repo. When you have a moment, would you mind giving it a quick look? No urgency. Happy to address any feedback. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the repository’s PR-time GitHub Actions workflows by explicitly setting least-privilege GITHUB_TOKEN permissions (contents: read) for the remaining validation checks that were previously inheriting organization defaults.
Changes:
- Add top-level
permissions: contents: readtovalidate-exceptions.yml. - Add top-level
permissions: contents: readtovalidate-csv.yml. - Add top-level
permissions: contents: readtoe2e-license-site.yml.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/validate-exceptions.yml | Explicitly restrict token permissions for JSON schema + consistency validation workflow. |
| .github/workflows/validate-csv.yml | Explicitly restrict token permissions for CSV lint workflow. |
| .github/workflows/e2e-license-site.yml | Explicitly restrict token permissions for Playwright PR e2e workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an explicit
permissions: contents: readblock to the three PR-time validation workflows still inheriting org defaults:e2e-license-site.yml— Playwright e2e for the License Exceptions site.validate-csv.yml—krook/csv-lintagainstproject-maintainers.csv.validate-exceptions.yml—ajvJSON Schema validation againstexceptions.json.YAML validated locally.